> On 2011-12-15 00:20:36, Benjamin Hindman wrote: > > src/slave/constants.hpp, line 14 > > <https://reviews.apache.org/r/2990/diff/3/?file=62012#file62012line14> > > > > Just put a todo at the top of the file that says: "Make these constants > > configurable."
Done. > On 2011-12-15 00:20:36, Benjamin Hindman wrote: > > src/slave/http.cpp, line 115 > > <https://reviews.apache.org/r/2990/diff/3/?file=62013#file62013line115> > > > > Indentation? Done. > On 2011-12-15 00:20:36, Benjamin Hindman wrote: > > src/slave/http.cpp, line 208 > > <https://reviews.apache.org/r/2990/diff/3/?file=62013#file62013line208> > > > > Indentation? Done. > On 2011-12-15 00:20:36, Benjamin Hindman wrote: > > src/webui/slave/index.tpl, line 94 > > <https://reviews.apache.org/r/2990/diff/3/?file=62018#file62018line94> > > > > Move the % back to the beginning of the line. Done. > On 2011-12-15 00:20:36, Benjamin Hindman wrote: > > src/webui/slave/index.tpl, line 101 > > <https://reviews.apache.org/r/2990/diff/3/?file=62018#file62018line101> > > > > Here too. Done. - Thomas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2990/#review3915 ----------------------------------------------------------- On 2012-01-09 19:29:36, Thomas Marshall wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2990/ > ----------------------------------------------------------- > > (Updated 2012-01-09 19:29:36) > > > Review request for mesos, Benjamin Hindman and Andy Konwinski. > > > Summary > ------- > > Added a framework history to the slave page, an executor history to the > framework page, and a task history to the executor page. Allows stdout and > stderr of executors to be viewed after they finish executing. > > > This addresses bug MESOS-8. > https://issues.apache.org/jira/browse/MESOS-8 > > > Diffs > ----- > > src/slave/constants.hpp 489640b > src/slave/http.cpp 18efd8c > src/slave/slave.hpp 37bbd8c > src/slave/slave.cpp 665ab7f > src/webui/slave/executor.tpl dd53464 > src/webui/slave/framework.tpl 9488da5 > src/webui/slave/index.tpl 0f18de6 > > Diff: https://reviews.apache.org/r/2990/diff > > > Testing > ------- > > > Thanks, > > Thomas > >
