[ 
https://issues.apache.org/jira/browse/MESOS-89?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13173817#comment-13173817
 ] 

[email protected] commented on MESOS-89:
----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3050/
-----------------------------------------------------------

(Updated 2011-12-21 03:24:51.902604)


Review request for mesos.


Changes
-------

Thanks for the feedback. I've made the requested changes. Please take another 
look.


Summary
-------

The first of several patches related to resource usage monitoring. This patch 
provides a collection of utilities for use on Linux for reading stats from 
proc. It is used by both the lxc and proc resource collectors.


This addresses bug MESOS-89.
    https://issues.apache.org/jira/browse/MESOS-89


Diffs (updated)
-----

  src/Makefile.in 516f128 
  src/monitoring/linux/proc_utils.hpp PRE-CREATION 
  src/monitoring/linux/proc_utils.cpp PRE-CREATION 
  src/tests/Makefile.in ea943f7 
  src/tests/proc_utils_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/3050/diff


Testing
-------

Sanity tests have been written in src/tests/proc_utils_tests.cpp for all 
utility functions, and functions have been tested ad hoc.


Thanks,

Alex


                
> create utilities to collect information from the proc filesystem
> ----------------------------------------------------------------
>
>                 Key: MESOS-89
>                 URL: https://issues.apache.org/jira/browse/MESOS-89
>             Project: Mesos
>          Issue Type: Sub-task
>          Components: slave
>         Environment: This is specific to Linux, as OS X does not have a proc 
> filesystem.
>            Reporter: Sam Whitlock
>            Assignee: Alex Degtiar
>            Priority: Minor
>              Labels: monitoring
>
> This is a utility for MESOS-38 https://issues.apache.org/jira/browse/MESOS-38
> Create a collection of utilities to read information from the proc 
> filesystem. This will be used in MESOS-38 to collect most of the information 
> for the process-based isolation usage reporting mechanism. These utilities 
> will also be used for certain functionality in monitoring lxc-based isolation 
> because not all of the information needed is available via the cgroup 
> interface, such as the start time of the container.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to