[
https://issues.apache.org/jira/browse/MESOS-89?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13204057#comment-13204057
]
[email protected] commented on MESOS-89:
----------------------------------------------------
bq. On 2012-02-07 18:14:30, Charles Reiss wrote:
bq. >
bq.
bq. Sam Whitlock wrote:
bq. What target should these go into in Makefile.am?
libmesos_no_third_party_la_SOURCES seems to be the one that all the source
files are being added to.
bq.
bq. Charles Reiss wrote:
bq. libmesos_no_third_party_la would be fine for the non-test targets.
(The test ones probably go into the mesos_tests_SOURCES.)
bq.
Because some of the monitoring stuff is linux-specific, should it be
conditionally added to libmesos_no_third_party_la_SOURCES in the same way
lxc_isolation_module.cpp is?
It seems like all the hpp files are unconditionally added to
libmesos_no_third_party and linux-specific cpp files should only be added if
OS_LINUX is true. Is this correct?
- Sam
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3050/#review4868
-----------------------------------------------------------
On 2011-12-24 04:13:40, Alex Degtiar wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3050/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-12-24 04:13:40)
bq.
bq.
bq. Review request for mesos.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. The first of several patches related to resource usage monitoring. This
patch provides a collection of utilities for use on Linux for reading stats
from proc. It is used by both the lxc and proc resource collectors.
bq.
bq.
bq. This addresses bug MESOS-89.
bq. https://issues.apache.org/jira/browse/MESOS-89
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/monitoring/linux/proc_utils.cpp PRE-CREATION
bq. src/tests/Makefile.in ea943f7
bq. src/tests/proc_utils_tests.cpp PRE-CREATION
bq. src/Makefile.in 516f128
bq. src/monitoring/linux/proc_utils.hpp PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/3050/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Sanity tests have been written in src/tests/proc_utils_tests.cpp for all
utility functions, and functions have been tested ad hoc.
bq.
bq.
bq. Thanks,
bq.
bq. Alex
bq.
bq.
> create utilities to collect information from the proc filesystem
> ----------------------------------------------------------------
>
> Key: MESOS-89
> URL: https://issues.apache.org/jira/browse/MESOS-89
> Project: Mesos
> Issue Type: Sub-task
> Components: slave
> Environment: This is specific to Linux, as OS X does not have a proc
> filesystem.
> Reporter: Sam Whitlock
> Assignee: Alex Degtiar
> Priority: Minor
> Labels: monitoring
>
> This is a utility for MESOS-38 https://issues.apache.org/jira/browse/MESOS-38
> Create a collection of utilities to read information from the proc
> filesystem. This will be used in MESOS-38 to collect most of the information
> for the process-based isolation usage reporting mechanism. These utilities
> will also be used for certain functionality in monitoring lxc-based isolation
> because not all of the information needed is available via the cgroup
> interface, such as the start time of the container.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
