> On 2012-01-10 14:26:24, John Sirois wrote: > > src/java/src/org/apache/mesos/Scheduler.java, line 57 > > <https://reviews.apache.org/r/3442/diff/1/?file=67453#file67453line57> > > > > There appears to be no need fo indexed access - Collection if you want > > to provide size, but it seems Iterable is fine here.
Going over the offers in the same order multiple times is useful in complex schedulers -- for example, we do it in Spark. I suggest leaving it this way, unless you want everyone to copy their Collection to a list. I can't anticipate a scenario when it would be more efficient to use an unordered collection here, and in other languages, such as Python, the collection will be ordered anyway. - Matei ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3442/#review4294 ----------------------------------------------------------- On 2012-01-10 06:48:03, Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3442/ > ----------------------------------------------------------- > > (Updated 2012-01-10 06:48:03) > > > Review request for mesos, Andy Konwinski, Charles Reiss, Matei Zaharia, John > Sirois, and Vinod Kone. > > > Summary > ------- > > Provides initial documentation to the public interfaces (thanks to Vinod Kone > for pairing with me on this). > > > This addresses bug MESOS-45. > https://issues.apache.org/jira/browse/MESOS-45 > > > Diffs > ----- > > include/mesos/executor.hpp d883f1a > include/mesos/mesos.proto 77a9067 > include/mesos/scheduler.hpp 93dda98 > src/java/src/org/apache/mesos/Executor.java 5ad8cee > src/java/src/org/apache/mesos/ExecutorDriver.java be01d21 > src/java/src/org/apache/mesos/MesosExecutorDriver.java 399c8b8 > src/java/src/org/apache/mesos/MesosSchedulerDriver.java 04809a6 > src/java/src/org/apache/mesos/Scheduler.java 63a06fe > src/java/src/org/apache/mesos/SchedulerDriver.java 23a246c > src/python/src/mesos.py 5fc60e2 > > Diff: https://reviews.apache.org/r/3442/diff > > > Testing > ------- > > > Thanks, > > Benjamin > >
