> On 2012-01-10 14:26:24, John Sirois wrote: > > This is very, very helpful. Thanks. > > I focused on the javadoc but threw in java api nits as well (from the > > perspective of a mesos library maintainer). > > The javadoc should really follow > > http://www.oracle.com/technetwork/java/javase/documentation/index-137868.html, > > but the most glaring omissions are @parameter,@return docs.
Yes, I'd love to see these too. Perhaps this will get done in the second round, or could get contributed by someone else. > On 2012-01-10 14:26:24, John Sirois wrote: > > src/java/src/org/apache/mesos/Scheduler.java, line 39 > > <https://reviews.apache.org/r/3442/diff/1/?file=67453#file67453line39> > > > > The driver parameter in all methods other than register deserves > > explanation - must I use the it in the scope of the callback or is it > > always the same as the regsitered or ...? Done. > On 2012-01-10 14:26:24, John Sirois wrote: > > src/java/src/org/apache/mesos/SchedulerDriver.java, line 38 > > <https://reviews.apache.org/r/3442/diff/1/?file=67454#file67454line38> > > > > s/public // - these are redundant for interface members Done. > On 2012-01-10 14:26:24, John Sirois wrote: > > src/java/src/org/apache/mesos/SchedulerDriver.java, line 43 > > <https://reviews.apache.org/r/3442/diff/1/?file=67454#file67454line43> > > > > how does this stop relate to the overload? failover=true or false? Updated the comment. Thanks. > On 2012-01-10 14:26:24, John Sirois wrote: > > src/java/src/org/apache/mesos/SchedulerDriver.java, line 85 > > <https://reviews.apache.org/r/3442/diff/1/?file=67454#file67454line85> > > > > Is Iterable enough for the impl? - if so prefer it. This is a much more invasive change (updates to the JNI bindings are required). If you feel highly about this please create a JIRA, and feel free to submit a patch too!. ;) - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3442/#review4294 ----------------------------------------------------------- On 2012-01-10 06:48:03, Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3442/ > ----------------------------------------------------------- > > (Updated 2012-01-10 06:48:03) > > > Review request for mesos, Andy Konwinski, Charles Reiss, Matei Zaharia, John > Sirois, and Vinod Kone. > > > Summary > ------- > > Provides initial documentation to the public interfaces (thanks to Vinod Kone > for pairing with me on this). > > > This addresses bug MESOS-45. > https://issues.apache.org/jira/browse/MESOS-45 > > > Diffs > ----- > > include/mesos/executor.hpp d883f1a > include/mesos/mesos.proto 77a9067 > include/mesos/scheduler.hpp 93dda98 > src/java/src/org/apache/mesos/Executor.java 5ad8cee > src/java/src/org/apache/mesos/ExecutorDriver.java be01d21 > src/java/src/org/apache/mesos/MesosExecutorDriver.java 399c8b8 > src/java/src/org/apache/mesos/MesosSchedulerDriver.java 04809a6 > src/java/src/org/apache/mesos/Scheduler.java 63a06fe > src/java/src/org/apache/mesos/SchedulerDriver.java 23a246c > src/python/src/mesos.py 5fc60e2 > > Diff: https://reviews.apache.org/r/3442/diff > > > Testing > ------- > > > Thanks, > > Benjamin > >
