----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3562/#review4492 -----------------------------------------------------------
Ship it! I'll check this in right after I hear your thoughts re: webui. src/Makefile.am <https://reviews.apache.org/r/3562/#comment10081> This should have been moved to common/cache.hpp ... but it's probably okay to leave out of the distribution because it's not getting used. src/Makefile.am <https://reviews.apache.org/r/3562/#comment10082> Wow ... how did building even work? Good catch! src/Makefile.am <https://reviews.apache.org/r/3562/#comment10083> Ultimately this should be included for people that want to run a framework with a "local" cluster, and want to check out webui stuff. The alternative is to remove libwebui.la from the binaries right? src/Makefile.am <https://reviews.apache.org/r/3562/#comment10084> What the heck! How did I check that in!!!!!!!!!!! How did my last build work????? - Benjamin On 2012-01-20 06:34:32, Charles Reiss wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3562/ > ----------------------------------------------------------- > > (Updated 2012-01-20 06:34:32) > > > Review request for mesos and Benjamin Hindman. > > > Summary > ------- > > A few things seemed to sneak through your autotools commit. > > Most of these are typos; including libwebui.la in libmesos_no_third_party.la > presumably isn't. If you're going to include it, then you need to deal with > $(WEBUI_LDFLAGS), but presumably you didn't mean to since you link it in > again for mesos-master, etc. > > > Diffs > ----- > > src/Makefile.am a8d317f > > Diff: https://reviews.apache.org/r/3562/diff > > > Testing > ------- > > > Thanks, > > Charles > >
