> On 2012-01-20 17:03:55, Benjamin Hindman wrote: > > src/Makefile.am, line 237 > > <https://reviews.apache.org/r/3562/diff/2/?file=69975#file69975line237> > > > > Ultimately this should be included for people that want to run a > > framework with a "local" cluster, and want to check out webui stuff. The > > alternative is to remove libwebui.la from the binaries right? > > Charles Reiss wrote: > The alternative is to remove libwebui.la from the binaries _and_ move > WEBUI_LDFLAGS into libmesos somehow (so Python is linked in; otherwise I get > a linker error).
Right, I'll keep your changes as they are and get this checked in. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3562/#review4492 ----------------------------------------------------------- On 2012-01-20 06:34:32, Charles Reiss wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3562/ > ----------------------------------------------------------- > > (Updated 2012-01-20 06:34:32) > > > Review request for mesos and Benjamin Hindman. > > > Summary > ------- > > A few things seemed to sneak through your autotools commit. > > Most of these are typos; including libwebui.la in libmesos_no_third_party.la > presumably isn't. If you're going to include it, then you need to deal with > $(WEBUI_LDFLAGS), but presumably you didn't mean to since you link it in > again for mesos-master, etc. > > > Diffs > ----- > > src/Makefile.am a8d317f > > Diff: https://reviews.apache.org/r/3562/diff > > > Testing > ------- > > > Thanks, > > Charles > >
