> On 2012-03-06 01:36:10, Charles Reiss wrote: > > src/Makefile.am, line 237 > > <https://reviews.apache.org/r/4187/diff/2/?file=88440#file88440line237> > > > > Can we please not modify $(srcdir) during an out-of-source build? > > > > Also, why was the previous definition of FORCE insufficient? > > Benjamin Hindman wrote: > It previously only re-linked the libbuild.la, rather than actually > recompiling build.cpp. If you have a better suggestion, I'd love to hear it.
Wouldn't making $(srcdir)/common/build.cpp depend on FORCE work? - Charles ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4187/#review5626 ----------------------------------------------------------- On 2012-03-06 00:45:45, Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4187/ > ----------------------------------------------------------- > > (Updated 2012-03-06 00:45:45) > > > Review request for mesos and Charles Reiss. > > > Summary > ------- > > Build updates: > * Have libprocess only build a convenience library by default (so nothing > gets installed). > * Remove libev from Mesos makefiles (as well as src/python/setup.py.in). > * Actually force build.cpp to get recompiled. > * Added libleveldb.a directly to libmesos.la so that it wasn't included in > the installed libmesos.la in 'dependency_lib'. > * Added leveldb to python/setup.py.in (given the previous). > > NOTE: Unfortunately when installing there is still a > $(prefix)/include/libprocess directory created. It would be nice to eliminate > that! > > > Diffs > ----- > > configure.ac d61c893 > src/Makefile.am 1137a3e > src/python/native/proxy_scheduler.cpp bc0c43f > src/python/setup.py.in 472094e > third_party/libprocess/Makefile.am 48ee256 > third_party/libprocess/configure.ac ace13e0 > > Diff: https://reviews.apache.org/r/4187/diff > > > Testing > ------- > > make && make check && make install DESTDIR=/tmp/mesos > > > Thanks, > > Benjamin > >
