> On 2012-03-09 00:36:34, Charles Reiss wrote: > > LGTM.
Alright, I'm committing this without the forcing the rebuild of build.cpp complexities. We can revisit this in the future if we decide this is really important. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4187/#review5762 ----------------------------------------------------------- On 2012-03-08 23:47:37, Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4187/ > ----------------------------------------------------------- > > (Updated 2012-03-08 23:47:37) > > > Review request for mesos and Charles Reiss. > > > Summary > ------- > > Build updates: > * Have libprocess only build a convenience library by default (so nothing > gets installed). > * Remove libev from Mesos makefiles (as well as src/python/setup.py.in). > * Actually force build.cpp to get recompiled. > * Added libleveldb.a directly to libmesos.la so that it wasn't included in > the installed libmesos.la in 'dependency_lib'. > * Added leveldb to python/setup.py.in (given the previous). > > NOTE: Unfortunately when installing there is still a > $(prefix)/include/libprocess directory created. It would be nice to eliminate > that! > > > Diffs > ----- > > configure.ac d61c893 > src/Makefile.am 1137a3e > src/common/build.cpp e7b43c4 > src/common/build.cpp.in PRE-CREATION > src/python/native/proxy_scheduler.cpp bc0c43f > src/python/setup.py.in 472094e > third_party/libprocess/Makefile.am 48ee256 > third_party/libprocess/configure.ac ace13e0 > > Diff: https://reviews.apache.org/r/4187/diff > > > Testing > ------- > > make && make check && make install DESTDIR=/tmp/mesos > > > Thanks, > > Benjamin > >
