----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4298/#review5856 -----------------------------------------------------------
configure.ac <https://reviews.apache.org/r/4298/#comment12753> Do we want to bless anything with this version number until we think we have an actual release candidate? src/java/generated/org/apache/mesos/MesosNativeLibrary.java.in <https://reviews.apache.org/r/4298/#comment12750> I assume you're deliberately not doing mesos-@PACKAGE_VERSION@ here? src/java/jni/convert.cpp <https://reviews.apache.org/r/4298/#comment12752> Please make this error message indicate which version number comes from Java and which comes from the .so/.dll/.dylib - Charles On 2012-03-12 21:35:22, Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4298/ > ----------------------------------------------------------- > > (Updated 2012-03-12 21:35:22) > > > Review request for mesos and Charles Reiss. > > > Summary > ------- > > See summary. > > > Diffs > ----- > > configure.ac de26a05 > include/mesos/mesos.hpp 41ddfb6 > include/mesos/mesos.hpp.in PRE-CREATION > src/Makefile.am 10dbafd > src/common/build.hpp 868cf97 > src/examples/java/TestFramework.java ff8eb4b > src/java/generated/org/apache/mesos/MesosNativeLibrary.java.in PRE-CREATION > src/java/jni/convert.cpp 6db4f25 > src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp ab2925e > src/java/src/org/apache/mesos/MesosNativeLibrary.java 8a9615f > > Diff: https://reviews.apache.org/r/4298/diff > > > Testing > ------- > > make && make check && make hadoop && make install DESTDIR=/tmp/local > > > Thanks, > > Benjamin > >
