> On 2012-03-12 22:01:07, Charles Reiss wrote: > > configure.ac, line 21 > > <https://reviews.apache.org/r/4298/diff/1/?file=91267#file91267line21> > > > > Do we want to bless anything with this version number until we think we > > have an actual release candidate? > > Benjamin Hindman wrote: > I'd like to make 0.9.0 the release candidate. We were debating between > 0.9.0 and 1.0.0 but the latter implies a stable API, and I'd like to give us > a little bit of runway after the first release to shake out any cobwebs that > others might run across.
I don't have any objections to this, but I assume others will have opinions on it. > On 2012-03-12 22:01:07, Charles Reiss wrote: > > src/java/generated/org/apache/mesos/MesosNativeLibrary.java.in, line 46 > > <https://reviews.apache.org/r/4298/diff/1/?file=91273#file91273line46> > > > > I assume you're deliberately not doing mesos-@PACKAGE_VERSION@ here? > > Benjamin Hindman wrote: > Yes. My thinking was that if we had a versioning scheme we're comfortable > with we could imagine loading e.g., 2.6.8 even if MesosNativeLibrary was > built with 2.6.4 (as well as possibly SNAPSHOT versions). I assume you imagine that the C++ code is going to do that sort of compatibility check. - Charles ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4298/#review5856 ----------------------------------------------------------- On 2012-03-12 22:11:19, Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4298/ > ----------------------------------------------------------- > > (Updated 2012-03-12 22:11:19) > > > Review request for mesos and Charles Reiss. > > > Summary > ------- > > See summary. > > > Diffs > ----- > > configure.ac de26a05 > include/mesos/mesos.hpp 41ddfb6 > include/mesos/mesos.hpp.in PRE-CREATION > src/Makefile.am 10dbafd > src/common/build.hpp 868cf97 > src/examples/java/TestFramework.java ff8eb4b > src/java/generated/org/apache/mesos/MesosNativeLibrary.java.in PRE-CREATION > src/java/jni/convert.cpp 6db4f25 > src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp ab2925e > src/java/src/org/apache/mesos/MesosNativeLibrary.java 8a9615f > > Diff: https://reviews.apache.org/r/4298/diff > > > Testing > ------- > > make && make check && make hadoop && make install DESTDIR=/tmp/local > > > Thanks, > > Benjamin > >
