-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4355/
-----------------------------------------------------------
(Updated 2012-03-14 17:48:10.906132)
Review request for mesos, Benjamin Hindman and Jessica.
Changes
-------
Add note to description.
Summary (updated)
-------
libprocess currently binds to INADDR_ANY and uses the result of getsockname()
as __ip__, overwriting its reading of LIBPROCESS_IP. This patch should use the
environment variable setting (when it is not 0 == INADDR_ANY) when it is
supplied instead of using getsockname().
I think this bug is the cause of MESOS-165.
Note: I assumed that we are intentionally binding to INADDR_ANY regardless of
what LIBPROCESS_IP is set to, but this seems to indicate that our documentation
on the meaning of the 'ip' option is wrong. An alternate fix would be to change
process.cpp:1257 to use __ip__ for s_addr if it's not 0.
This addresses bug MESOS-165.
https://issues.apache.org/jira/browse/MESOS-165
Diffs
-----
third_party/libprocess/src/process.cpp 7433be8
Diff: https://reviews.apache.org/r/4355/diff
Testing
-------
Thanks,
Charles
