-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4355/#review6143
-----------------------------------------------------------

Ship it!


Thanks Charles.

- Benjamin


On 2012-03-20 18:04:43, Charles Reiss wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4355/
> -----------------------------------------------------------
> 
> (Updated 2012-03-20 18:04:43)
> 
> 
> Review request for mesos, Benjamin Hindman and Jessica.
> 
> 
> Summary
> -------
> 
> libprocess currently binds to INADDR_ANY and uses the result of getsockname() 
> as __ip__, overwriting its reading of LIBPROCESS_IP. This patch should use 
> the environment variable setting (when it is not 0 == INADDR_ANY) when it is 
> supplied to choose the address to bind() to.
> 
> I think this bug is the cause of MESOS-165.
> 
> 
> This addresses bug MESOS-165.
>     https://issues.apache.org/jira/browse/MESOS-165
> 
> 
> Diffs
> -----
> 
>   third_party/libprocess/src/process.cpp 7433be8 
> 
> Diff: https://reviews.apache.org/r/4355/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Charles
> 
>

Reply via email to