> On 2012-03-20 15:45:01, John Sirois wrote: > >
Thank you, submitting. > On 2012-03-20 15:45:01, John Sirois wrote: > > src/common/try.hpp, line 41 > > <https://reviews.apache.org/r/4408/diff/1/?file=93749#file93749line41> > > > > why not private / force Try::error("") ? Because I figured the code looked better when you do something like: Try<T> t; if (conditional) { t = Try<T>::some(expression); } else { t = Try<T>::some(expression); } if (t.isSome()) { ... than: Try<T> t = Try<T>::error("Uninitialized Try"); ... > On 2012-03-20 15:45:01, John Sirois wrote: > > src/master/master.cpp, line 1440 > > <https://reviews.apache.org/r/4408/diff/1/?file=93751#file93751line1440> > > > > Are there sanity checks anywhere that task.has_command() != > > task.has_executor() Great question! Yes, when you try and launch a task we make sure that only one of CommandInfo or ExecutorInfo is set (and fail the task if not). - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4408/#review6122 ----------------------------------------------------------- On 2012-03-20 00:55:15, Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4408/ > ----------------------------------------------------------- > > (Updated 2012-03-20 00:55:15) > > > Review request for mesos, John Sirois and Vinod Kone. > > > Summary > ------- > > Made sure the slave sends status updates for tasks launched via a CommandInfo > and updated Task to make 'executor_id' optional for the cases when a task was > launched with a CommandInfo (w/ corresponding changes in the master and > slave)."[commandinfo_exit 4858fe1] Made sure the slave sends status updates > for tasks launched via a CommandInfo and updated Task to make 'executor_id' > optional for the cases when a task was launched with a CommandInfo (w/ > corresponding changes in the master and slave). > > > Diffs > ----- > > src/common/try.hpp ed5611b > src/launcher/executor.cpp aac1053 > src/master/master.cpp 0222bb2 > src/messages/messages.proto 11a2c41 > src/slave/reaper.cpp 93e47e7 > src/slave/slave.hpp de304cb > src/slave/slave.cpp ddd1874 > > Diff: https://reviews.apache.org/r/4408/diff > > > Testing > ------- > > make check > > > Thanks, > > Benjamin > >
