> On 2012-03-20 22:10:29, Vinod Kone wrote: > > src/launcher/executor.cpp, line 66 > > <https://reviews.apache.org/r/4408/diff/1/?file=93750#file93750line66> > > > > redundant due to the CHECK above
Fixed now in https://reviews.apache.org/r/4420. > On 2012-03-20 22:10:29, Vinod Kone wrote: > > src/slave/reaper.cpp, line 62 > > <https://reviews.apache.org/r/4408/diff/1/?file=93753#file93753line62> > > > > why do you need this? You could imagine a user attaching to a running executor to debug. This stops the process, but it might be resumed. We don't want to treat the stop as an exited/terminated executor. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4408/#review6106 ----------------------------------------------------------- On 2012-03-20 00:55:15, Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4408/ > ----------------------------------------------------------- > > (Updated 2012-03-20 00:55:15) > > > Review request for mesos, John Sirois and Vinod Kone. > > > Summary > ------- > > Made sure the slave sends status updates for tasks launched via a CommandInfo > and updated Task to make 'executor_id' optional for the cases when a task was > launched with a CommandInfo (w/ corresponding changes in the master and > slave)."[commandinfo_exit 4858fe1] Made sure the slave sends status updates > for tasks launched via a CommandInfo and updated Task to make 'executor_id' > optional for the cases when a task was launched with a CommandInfo (w/ > corresponding changes in the master and slave). > > > Diffs > ----- > > src/common/try.hpp ed5611b > src/launcher/executor.cpp aac1053 > src/master/master.cpp 0222bb2 > src/messages/messages.proto 11a2c41 > src/slave/reaper.cpp 93e47e7 > src/slave/slave.hpp de304cb > src/slave/slave.cpp ddd1874 > > Diff: https://reviews.apache.org/r/4408/diff > > > Testing > ------- > > make check > > > Thanks, > > Benjamin > >
