[
https://issues.apache.org/jira/browse/MESOS-171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13239114#comment-13239114
]
[email protected] commented on MESOS-171:
-----------------------------------------------------
bq. On 2012-03-26 20:03:00, Benjamin Hindman wrote:
bq. > include/mesos/mesos.proto, line 94
bq. > <https://reviews.apache.org/r/4485/diff/2/?file=95884#file95884line94>
bq. >
bq. > You shouldn't link this protobuf explicitly to the downloading of
files before running the executor command. Otherwise if you prefer to do it
that way, embed the message in CommandInfo please.
fixed. dropped it inside CommandInfo
bq. On 2012-03-26 20:03:00, Benjamin Hindman wrote:
bq. > src/common/type_utils.hpp, lines 208-225
bq. > <https://reviews.apache.org/r/4485/diff/2/?file=95885#file95885line208>
bq. >
bq. > Factor out into operator == for URI please.
done
bq. On 2012-03-26 20:03:00, Benjamin Hindman wrote:
bq. > src/launcher/launcher.cpp, line 274
bq. > <https://reviews.apache.org/r/4485/diff/2/?file=95891#file95891line274>
bq. >
bq. > Indent.
done
bq. On 2012-03-26 20:03:00, Benjamin Hindman wrote:
bq. > src/launcher/launcher.cpp, line 306
bq. > <https://reviews.apache.org/r/4485/diff/2/?file=95891#file95891line306>
bq. >
bq. > Space after foreach.
done
bq. On 2012-03-26 20:03:00, Benjamin Hindman wrote:
bq. > src/launcher/launcher.cpp, line 312
bq. > <https://reviews.apache.org/r/4485/diff/2/?file=95891#file95891line312>
bq. >
bq. > s/r/R
fixed
bq. On 2012-03-26 20:03:00, Benjamin Hindman wrote:
bq. > src/launcher/launcher.cpp, lines 313-315
bq. > <https://reviews.apache.org/r/4485/diff/2/?file=95891#file95891line313>
bq. >
bq. > strings::trim?
cool..done
bq. On 2012-03-26 20:03:00, Benjamin Hindman wrote:
bq. > src/launcher/main.cpp, line 45
bq. > <https://reviews.apache.org/r/4485/diff/2/?file=95892#file95892line45>
bq. >
bq. > Factor getenv("MESOS_EXECUTOR_URIS") into a local string uris, then
you won't have to wrap this line.
done
bq. On 2012-03-26 20:03:00, Benjamin Hindman wrote:
bq. > src/launcher/main.cpp, line 47
bq. > <https://reviews.apache.org/r/4485/diff/2/?file=95892#file95892line47>
bq. >
bq. > s/d/D
done
bq. On 2012-03-26 20:03:00, Benjamin Hindman wrote:
bq. > src/launcher/main.cpp, line 53
bq. > <https://reviews.apache.org/r/4485/diff/2/?file=95892#file95892line53>
bq. >
bq. > Space around '+'.
done
bq. On 2012-03-26 20:03:00, Benjamin Hindman wrote:
bq. > src/launcher/main.cpp, line 44
bq. > <https://reviews.apache.org/r/4485/diff/2/?file=95892#file95892line44>
bq. >
bq. > Space after foreach.
done
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4485/#review6360
-----------------------------------------------------------
On 2012-03-26 18:39:25, Vinod Kone wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4485/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-26 18:39:25)
bq.
bq.
bq. Review request for mesos, Benjamin Hindman and John Sirois.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. CommandInfo now accepts a list of URIs.
bq.
bq. Also added the ability to selectively set the executable
bq. bit on the downloaded files.
bq.
bq.
bq. This addresses bug mesos-171.
bq. https://issues.apache.org/jira/browse/mesos-171
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. include/mesos/mesos.proto 23aad17
bq. src/common/type_utils.hpp 557abd7
bq. src/examples/java/TestFramework.java f86646b
bq. src/examples/java/TestMultipleExecutorsFramework.java cdbcc48
bq. src/examples/long_lived_framework.cpp 2775f5a
bq. src/examples/test_framework.cpp 622f6ac
bq. src/launcher/launcher.hpp b48d97c
bq. src/launcher/launcher.cpp 8545193
bq. src/launcher/main.cpp 80567e9
bq. src/slave/http.cpp b9f3232
bq. src/slave/lxc_isolation_module.cpp aff6da6
bq. src/slave/process_based_isolation_module.cpp 4280410
bq.
bq. Diff: https://reviews.apache.org/r/4485/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. make check.
bq.
bq. Yet to test it on a linux machine, as some of the changes affect the lxc
code.
bq.
bq.
bq. Thanks,
bq.
bq. Vinod
bq.
bq.
> Make CommandInfo 'uri' field be repeated, possibly making a URI embedded
> message to describe whether or not we should 'chmod +x' the resulting
> resource.
> --------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: MESOS-171
> URL: https://issues.apache.org/jira/browse/MESOS-171
> Project: Mesos
> Issue Type: Improvement
> Reporter: Benjamin Hindman
> Assignee: Vinod Kone
> Priority: Critical
>
> As a final API change related to CommandInfo:
> (a) Make the CommandInfo "uri" field be repeated instead of optional and (b)
> change the launcher to download each of the uri's and (c) add a comment above
> CommandInfo in mesos.proto that says we 'chmod +x' each uri (or figure out a
> way to possible "tag" which uris we want to 'chmod +x') and (d) have the
> scheduler make sure that each uri starts with a protocol (but don't currently
> support file://).
> It might make sense to add something along the lines of:
> message URI {
> required string value = 1;
> optional boolean executable = 2;
> }
> To decide whether or not we should download and make the artifact executable
> (via 'chmod +x').
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
