[
https://issues.apache.org/jira/browse/MESOS-171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13239119#comment-13239119
]
[email protected] commented on MESOS-171:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4485/
-----------------------------------------------------------
(Updated 2012-03-27 02:14:27.774818)
Review request for mesos, Benjamin Hindman and John Sirois.
Changes
-------
ben's comments.
Summary
-------
CommandInfo now accepts a list of URIs.
Also added the ability to selectively set the executable
bit on the downloaded files.
This addresses bug mesos-171.
https://issues.apache.org/jira/browse/mesos-171
Diffs (updated)
-----
include/mesos/mesos.proto 23aad17
src/common/type_utils.hpp 557abd7
src/examples/java/TestFramework.java f86646b
src/examples/java/TestMultipleExecutorsFramework.java cdbcc48
src/examples/long_lived_framework.cpp 2775f5a
src/examples/test_framework.cpp 622f6ac
src/launcher/launcher.hpp b48d97c
src/launcher/launcher.cpp 8545193
src/launcher/main.cpp 80567e9
src/slave/http.cpp b9f3232
src/slave/lxc_isolation_module.cpp aff6da6
src/slave/process_based_isolation_module.cpp 4280410
Diff: https://reviews.apache.org/r/4485/diff
Testing
-------
make check.
Yet to test it on a linux machine, as some of the changes affect the lxc code.
Thanks,
Vinod
> Make CommandInfo 'uri' field be repeated, possibly making a URI embedded
> message to describe whether or not we should 'chmod +x' the resulting
> resource.
> --------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: MESOS-171
> URL: https://issues.apache.org/jira/browse/MESOS-171
> Project: Mesos
> Issue Type: Improvement
> Reporter: Benjamin Hindman
> Assignee: Vinod Kone
> Priority: Critical
>
> As a final API change related to CommandInfo:
> (a) Make the CommandInfo "uri" field be repeated instead of optional and (b)
> change the launcher to download each of the uri's and (c) add a comment above
> CommandInfo in mesos.proto that says we 'chmod +x' each uri (or figure out a
> way to possible "tag" which uris we want to 'chmod +x') and (d) have the
> scheduler make sure that each uri starts with a protocol (but don't currently
> support file://).
> It might make sense to add something along the lines of:
> message URI {
> required string value = 1;
> optional boolean executable = 2;
> }
> To decide whether or not we should download and make the artifact executable
> (via 'chmod +x').
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
