-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4533/
-----------------------------------------------------------
(Updated 2012-03-31 21:57:43.283485)
Review request for mesos and Benjamin Hindman.
Changes
-------
Updated logic to use DEFAULT_FRAMEWORK_FAILOVER_TIMEOUT if specified timeout <=
0.
Summary
-------
When I started this project, it was somewhat complicated, but with the recent
update that passes FrameworkInfo protobufs into the MesosSchedulerDriver, all
that was necessary to allow frameworks to set their own timeouts was to add
timeout as a field in FrameworkInfo and tell master.cpp to use this value. I
made it optional since some people might not care to set it and it would just
be an added complication, but I also added it to all three of the
test_frameworks (C++, Java, Python) to demonstrate its use.
The choice for DEFAULT_FRAMEWORK_FAILOVER_TIMEOUT and
MAX_FRAMEWORK_FAILOVER_TIMEOUT was basically arbitrary, so I'm open to
suggestions on what might be more appropriate.
This addresses bug MESOS-143.
https://issues.apache.org/jira/browse/MESOS-143
Diffs (updated)
-----
include/mesos/mesos.proto 75eee57
include/mesos/scheduler.hpp dd09e3d
src/examples/java/TestFramework.java 4975760
src/examples/python/test_framework.py dd9cf98
src/examples/test_framework.cpp c408692
src/master/constants.hpp 8248475
src/master/master.hpp 8a34d7e
src/master/master.cpp 4dc9ee0
Diff: https://reviews.apache.org/r/4533/diff
Testing
-------
Thanks,
Thomas
