----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4533/#review7202 -----------------------------------------------------------
Ship it! THANK YOU THOMAS! I'm committing this now. - Benjamin On 2012-04-06 23:44:54, Thomas Marshall wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4533/ > ----------------------------------------------------------- > > (Updated 2012-04-06 23:44:54) > > > Review request for mesos and Benjamin Hindman. > > > Summary > ------- > > When I started this project, it was somewhat complicated, but with the recent > update that passes FrameworkInfo protobufs into the MesosSchedulerDriver, all > that was necessary to allow frameworks to set their own timeouts was to add > timeout as a field in FrameworkInfo and tell master.cpp to use this value. I > made it optional since some people might not care to set it and it would just > be an added complication, but I also added it to all three of the > test_frameworks (C++, Java, Python) to demonstrate its use. > > The choice for DEFAULT_FRAMEWORK_FAILOVER_TIMEOUT and > MAX_FRAMEWORK_FAILOVER_TIMEOUT was basically arbitrary, so I'm open to > suggestions on what might be more appropriate. > > > This addresses bug MESOS-143. > https://issues.apache.org/jira/browse/MESOS-143 > > > Diffs > ----- > > src/master/master.cpp 4dc9ee0 > src/master/master.hpp 8a34d7e > src/master/constants.hpp 8248475 > include/mesos/mesos.proto 75eee57 > include/mesos/scheduler.hpp c2acf0d > > Diff: https://reviews.apache.org/r/4533/diff > > > Testing > ------- > > > Thanks, > > Thomas > >
