----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4844/#review7189 -----------------------------------------------------------
Ship it! src/zookeeper/group.cpp <https://reviews.apache.org/r/4844/#comment15872> consider foreachpair src/zookeeper/group.cpp <https://reviews.apache.org/r/4844/#comment15873> s/onowned/unowned/ src/zookeeper/group.cpp <https://reviews.apache.org/r/4844/#comment15874> should this be == 1? src/zookeeper/group.cpp <https://reviews.apache.org/r/4844/#comment15876> consider foreachpair here and below - Vinod On 2012-04-23 18:49:26, Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4844/ > ----------------------------------------------------------- > > (Updated 2012-04-23 18:49:26) > > > Review request for mesos, John Sirois and Vinod Kone. > > > Summary > ------- > > (1) Renamed Group::info to Group::data (and associated changes). > (2) Added Group::Membership::watch to explicitly watch for a single > membership's cancellation (and associated GroupProcess changes). > (3) Fixed a but in GroupProcess::update that was deleting a Watch object when > also re-enqueueing it. > (4) Updated the GroupProcess destructor to fail all outstanding futures > associated with the Group. > > > Diffs > ----- > > src/log/network.hpp 0f7fefd > src/tests/zookeeper_tests.cpp a852103 > src/zookeeper/group.hpp 695a8ab > src/zookeeper/group.cpp c9122f6 > > Diff: https://reviews.apache.org/r/4844/diff > > > Testing > ------- > > make check > > > Thanks, > > Benjamin > >
