> On 2012-04-24 19:27:14, John Sirois wrote: > > src/zookeeper/group.hpp, line 61 > > <https://reviews.apache.org/r/4844/diff/2/?file=104001#file104001line61> > > > > I'm not finding a way to read this sanely: > > ~'returns true if cancelled.../ <-> membership.watch() > > > > IIUC all of these are more clear names: > > cancelled() > > withdrawn() > > discarded() > > abandoned() > > > > Each says to me the membership was chosen to be withdrawn by the user > > (vs via session expiry). > > > >
Done. > On 2012-04-24 19:27:14, John Sirois wrote: > > src/zookeeper/group.hpp, line 102 > > <https://reviews.apache.org/r/4844/diff/2/?file=104001#file104001line102> > > > > s/dat/data/ Done. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4844/#review7182 ----------------------------------------------------------- On 2012-04-23 18:49:26, Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4844/ > ----------------------------------------------------------- > > (Updated 2012-04-23 18:49:26) > > > Review request for mesos, John Sirois and Vinod Kone. > > > Summary > ------- > > (1) Renamed Group::info to Group::data (and associated changes). > (2) Added Group::Membership::watch to explicitly watch for a single > membership's cancellation (and associated GroupProcess changes). > (3) Fixed a but in GroupProcess::update that was deleting a Watch object when > also re-enqueueing it. > (4) Updated the GroupProcess destructor to fail all outstanding futures > associated with the Group. > > > Diffs > ----- > > src/log/network.hpp 0f7fefd > src/tests/zookeeper_tests.cpp a852103 > src/zookeeper/group.hpp 695a8ab > src/zookeeper/group.cpp c9122f6 > > Diff: https://reviews.apache.org/r/4844/diff > > > Testing > ------- > > make check > > > Thanks, > > Benjamin > >
