----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4768/#review7541 -----------------------------------------------------------
Awesome refactor! Super excited to get this committed (and I think Jessica will be too!). Just a few more minor points (please address Jessica's comments too). Thank you! frameworks/mpi/README.txt <https://reviews.apache.org/r/4768/#comment16703> I know it's obvious, but you might want to remind users that you'll need to install mpich2 on every machine in your cluster?. frameworks/mpi/README.txt <https://reviews.apache.org/r/4768/#comment16701> Kill whitespace. frameworks/mpi/README.txt <https://reviews.apache.org/r/4768/#comment16702> Kill whitespace. frameworks/mpi/nmpiexec.py <https://reviews.apache.org/r/4768/#comment16704> s/mpd slots/mpd(s) frameworks/mpi/nmpiexec.py <https://reviews.apache.org/r/4768/#comment16707> If you move this check into the 'for offer in offers:' on line 60, then you'll only be doing the check and decline in one place (not also on lines 107 and 108). frameworks/mpi/nmpiexec.py <https://reviews.apache.org/r/4768/#comment16705> Again, I'm not sure how ifhn_slave is going to be used. Can you elaborate? frameworks/mpi/nmpiexec.py <https://reviews.apache.org/r/4768/#comment16706> I love the long options! Thank you! frameworks/mpi/nmpiexec.py <https://reviews.apache.org/r/4768/#comment16710> +1 to Jessica's comment. frameworks/mpi/nmpiexec.py <https://reviews.apache.org/r/4768/#comment16708> +1 to Jessica's comment. frameworks/mpi/nmpiexec.py <https://reviews.apache.org/r/4768/#comment16709> mpdtraceerr is not used, kill it please. - Benjamin On 2012-05-02 13:29:50, Harvey Feng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4768/ > ----------------------------------------------------------- > > (Updated 2012-05-02 13:29:50) > > > Review request for mesos, Benjamin Hindman, Charles Reiss, and Jessica. > > > Summary > ------- > > Some updates to point out: > > -nmpiexec.py > -> 'mpdallexit' should terminate all slaves' mpds in the ring. I moved > 'driver.stop()' to statusUpdate() so that it stops when all tasks have been > finished, which occurs when the executor's launched mpd processes have all > exited. > -startmpd.py > -> Didn't remove cleanup(), and added code in shutdown() that manually > kills mpd processes. They might be useful during abnormal (cleanup) and > normal (shutdown) framework/executor termination...I think. cleanup() still > terminates all mpd's in the slave, but shutdown doesn't. > -> killtask() stops the mpd associated with the given tid. > -> Task states update nicely now. They correspond to the state of a task's > associated mpd process. > -Readme > -> Included additional info on how to setup and run MPICH2 1.2 and nmpiexec > on OS X and Ubuntu/Linux > > > This addresses bug MESOS-183. > https://issues.apache.org/jira/browse/MESOS-183 > > > Diffs > ----- > > frameworks/mpi/README.txt cdb4553 > frameworks/mpi/nmpiexec 517bdbc > frameworks/mpi/nmpiexec.py a5db9c0 > frameworks/mpi/startmpd.py 8eeba5e > frameworks/mpi/startmpd.sh 44faa05 > > Diff: https://reviews.apache.org/r/4768/diff > > > Testing > ------- > > > Thanks, > > Harvey > >
