> On 2012-05-07 19:19:17, Jessica wrote: > > frameworks/mpi/nmpiexec.py, line 118 > > <https://reviews.apache.org/r/4768/diff/5/?file=105963#file105963line118> > > > > I agree with Benjamin--ifhn_slave probably needs to go. I've created a > > new issue (MESOS-189) for configuring IP addresses that I think is relevant. > > > > Also... technically, you should use "is" and "is not" instead of "==" > > and "!=" to compare against None. This is the pythonic (and minutely > > faster) way.
Ok, switched from "==" to "is" > On 2012-05-07 19:19:17, Jessica wrote: > > frameworks/mpi/nmpiexec.py, line 186 > > <https://reviews.apache.org/r/4768/diff/5/?file=105963#file105963line186> > > > > I'd recommend passing default='' to parser.add_option so that you don't > > have to check if path is None later in the code. (This will also simplify > > calls to os.path.join since you won't have to check the value of path > > first.) Yup, this leaves just one "os.path.join()" call. - Harvey ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4768/#review7651 ----------------------------------------------------------- On 2012-05-08 01:29:06, Harvey Feng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4768/ > ----------------------------------------------------------- > > (Updated 2012-05-08 01:29:06) > > > Review request for mesos, Benjamin Hindman, Charles Reiss, and Jessica. > > > Summary > ------- > > Some updates to point out: > > -nmpiexec.py > -> 'mpdallexit' should terminate all slaves' mpds in the ring. I moved > 'driver.stop()' to statusUpdate() so that it stops when all tasks have been > finished, which occurs when the executor's launched mpd processes have all > exited. > -startmpd.py > -> Didn't remove cleanup(), and added code in shutdown() that manually > kills mpd processes. They might be useful during abnormal (cleanup) and > normal (shutdown) framework/executor termination...I think. cleanup() still > terminates all mpd's in the slave, but shutdown doesn't. > -> killtask() stops the mpd associated with the given tid. > -> Task states update nicely now. They correspond to the state of a task's > associated mpd process. > -Readme > -> Included additional info on how to setup and run MPICH2 1.2 and nmpiexec > on OS X and Ubuntu/Linux > > > This addresses bug MESOS-183. > https://issues.apache.org/jira/browse/MESOS-183 > > > Diffs > ----- > > frameworks/mpi/README.txt cdb4553 > frameworks/mpi/nmpiexec 517bdbc > frameworks/mpi/nmpiexec.py a5db9c0 > frameworks/mpi/startmpd.py 8eeba5e > frameworks/mpi/startmpd.sh 44faa05 > > Diff: https://reviews.apache.org/r/4768/diff > > > Testing > ------- > > > Thanks, > > Harvey > >
