> On 2012-05-09 06:29:18, Benjamin Hindman wrote: > >
also updated seconds.hpp (now called time.hpp) with hours and minutes > On 2012-05-09 06:29:18, Benjamin Hindman wrote: > > src/common/utils.hpp, line 236 > > <https://reviews.apache.org/r/5072/diff/1/?file=107942#file107942line236> > > > > Why not return an error? done > On 2012-05-09 06:29:18, Benjamin Hindman wrote: > > src/common/utils.hpp, line 241 > > <https://reviews.apache.org/r/5072/diff/1/?file=107942#file107942line241> > > > > Newline. done > On 2012-05-09 06:29:18, Benjamin Hindman wrote: > > src/slave/slave.hpp, line 142 > > <https://reviews.apache.org/r/5072/diff/1/?file=107944#file107944line142> > > > > const & i didn't use a reference because the executor->directory would be deleted. anyhow, now i'm making a copy at the call site and using const & > On 2012-05-09 06:29:18, Benjamin Hindman wrote: > > src/slave/slave.cpp, line 1521 > > <https://reviews.apache.org/r/5072/diff/1/?file=107945#file107945line1521> > > > > IIUC, at this point, no executors should be live. yes > On 2012-05-09 06:29:18, Benjamin Hindman wrote: > > src/slave/slave.cpp, line 1526 > > <https://reviews.apache.org/r/5072/diff/1/?file=107945#file107945line1526> > > > > Clock::now. done > On 2012-05-09 06:29:18, Benjamin Hindman wrote: > > src/slave/slave.cpp, line 1522 > > <https://reviews.apache.org/r/5072/diff/1/?file=107945#file107945line1522> > > > > ? oops..fixed - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5072/#review7722 ----------------------------------------------------------- On 2012-05-09 02:10:27, Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5072/ > ----------------------------------------------------------- > > (Updated 2012-05-09 02:10:27) > > > Review request for mesos, Benjamin Hindman, John Sirois, and Brian Wickman. > > > Summary > ------- > > This is the first cut for GC inside the slave. > > There are 2 kinds of gc going on > > --> Executor work dirs -- These get deleted whenever (after a timeout) an > executor exits/shutdown > --> Old slave dirs -- These get deleted when the slave gets registered for > the first time on a startup > > > Diffs > ----- > > src/slave/slave.hpp 08a29d8 > src/slave/slave.cpp 09a8396 > src/common/utils.hpp 1d81e21 > src/slave/constants.hpp f0c8679 > > Diff: https://reviews.apache.org/r/5072/diff > > > Testing > ------- > > make check scucceeds. > > Yet to write GC specific tests. > > > Thanks, > > Vinod > >
