----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5072/ -----------------------------------------------------------
(Updated 2012-05-11 19:37:09.285251) Review request for mesos, Benjamin Hindman, John Sirois, and Brian Wickman. Changes ------- john and ben's comments. also extended seconds.hpp and renamed to time.hpp. Summary ------- This is the first cut for GC inside the slave. There are 2 kinds of gc going on --> Executor work dirs -- These get deleted whenever (after a timeout) an executor exits/shutdown --> Old slave dirs -- These get deleted when the slave gets registered for the first time on a startup Diffs (updated) ----- src/Makefile.am cd503a8 src/common/seconds.hpp 5ae088a src/common/timer.hpp 71dc493 src/common/utils.hpp 1d81e21 src/log/coordinator.hpp b881c6a src/log/log.hpp 79bb738 src/log/network.hpp 6ce6a53 src/master/frameworks_manager.hpp 31d708b src/slave/constants.hpp f0c8679 src/slave/slave.hpp 08a29d8 src/slave/slave.cpp 09a8396 src/tests/base_zookeeper_test.hpp f35acc0 src/tests/fault_tolerance_tests.cpp 6772daf src/zookeeper/group.hpp 695a8ab src/zookeeper/zookeeper.hpp 5043a64 Diff: https://reviews.apache.org/r/5072/diff Testing ------- make check scucceeds. Yet to write GC specific tests. Thanks, Vinod
