----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5187/#review8052 -----------------------------------------------------------
include/mesos/mesos.proto <https://reviews.apache.org/r/5187/#comment17506> Actually, this should just say that one of ExecutorInfo or CommandInfo should be set, rather than mention anything about an "ephemeral" executor for the CommandInfo case. src/launcher/launcher.cpp <https://reviews.apache.org/r/5187/#comment17507> Use utils::os::system. src/launcher/launcher.cpp <https://reviews.apache.org/r/5187/#comment17508> Use utils::os::chmod. src/launcher/launcher.cpp <https://reviews.apache.org/r/5187/#comment17509> Wrap this in '{' '}'. - Benjamin On 2012-05-22 00:41:57, Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5187/ > ----------------------------------------------------------- > > (Updated 2012-05-22 00:41:57) > > > Review request for mesos, Benjamin Hindman and John Sirois. > > > Summary > ------- > > Executor launcher now supports copying executor from local file system > > > Diffs > ----- > > include/mesos/mesos.proto ab02b95 > src/launcher/launcher.cpp 5d8ef6c > > Diff: https://reviews.apache.org/r/5187/diff > > > Testing > ------- > > Tested with AB. > > Also, > make check. > > > Thanks, > > Vinod > >
