> On 2012-05-23 05:36:47, Benjamin Hindman wrote: > > include/mesos/mesos.proto, line 271 > > <https://reviews.apache.org/r/5187/diff/1/?file=109764#file109764line271> > > > > Actually, this should just say that one of ExecutorInfo or CommandInfo > > should be set, rather than mention anything about an "ephemeral" executor > > for the CommandInfo case.
done > On 2012-05-23 05:36:47, Benjamin Hindman wrote: > > src/launcher/launcher.cpp, line 231 > > <https://reviews.apache.org/r/5187/diff/1/?file=109765#file109765line231> > > > > Use utils::os::system. done..here and everywhere else > On 2012-05-23 05:36:47, Benjamin Hindman wrote: > > src/launcher/launcher.cpp, line 237 > > <https://reviews.apache.org/r/5187/diff/1/?file=109765#file109765line237> > > > > Use utils::os::chmod. doesnt exist. wrote one. > On 2012-05-23 05:36:47, Benjamin Hindman wrote: > > src/launcher/launcher.cpp, line 239 > > <https://reviews.apache.org/r/5187/diff/1/?file=109765#file109765line239> > > > > Wrap this in '{' '}'. done - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5187/#review8052 ----------------------------------------------------------- On 2012-05-22 00:41:57, Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5187/ > ----------------------------------------------------------- > > (Updated 2012-05-22 00:41:57) > > > Review request for mesos, Benjamin Hindman and John Sirois. > > > Summary > ------- > > Executor launcher now supports copying executor from local file system > > > Diffs > ----- > > include/mesos/mesos.proto ab02b95 > src/launcher/launcher.cpp 5d8ef6c > > Diff: https://reviews.apache.org/r/5187/diff > > > Testing > ------- > > Tested with AB. > > Also, > make check. > > > Thanks, > > Vinod > >
