> On 2012-05-30 00:04:14, Benjamin Hindman wrote: > > src/slave/process_based_isolation_module.cpp, line 147 > > <https://reviews.apache.org/r/5260/diff/3/?file=110557#file110557line147> > > > > Does the slave wait on the pipe forever here? Or does this cause the > > slave to fail?
good point. i wasn't able to grok what's happening inside glog/logging.h. To be safe, I'm explicitly calling _exit. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5260/#review8182 ----------------------------------------------------------- On 2012-05-29 23:27:57, Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5260/ > ----------------------------------------------------------- > > (Updated 2012-05-29 23:27:57) > > > Review request for mesos and Benjamin Hindman. > > > Summary > ------- > > Added killgrp() to process based isolation module. > > Also, updated killtree.sh to catch more zombies. > > > This addresses bug mesos-199. > https://issues.apache.org/jira/browse/mesos-199 > > > Diffs > ----- > > src/slave/process_based_isolation_module.cpp e76339c > > Diff: https://reviews.apache.org/r/5260/diff > > > Testing > ------- > > make check > > > Thanks, > > Vinod > >
