> On 2012-05-30 17:42:39, Benjamin Hindman wrote: > > src/slave/process_based_isolation_module.cpp, line 148 > > <https://reviews.apache.org/r/5260/diff/4/?file=110628#file110628line148> > > > > Wait, so I'm still confused by this. Does line 123 execute in this > > case? And is that your intention?
yes. since _exit() closes all open file descriptors, I expect 122 to get EOF and 123 to be executed. since this is a really bad situation (unable to find a setsid()able process) its ok for the slave to die. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5260/#review8221 ----------------------------------------------------------- On 2012-05-30 01:56:19, Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5260/ > ----------------------------------------------------------- > > (Updated 2012-05-30 01:56:19) > > > Review request for mesos and Benjamin Hindman. > > > Summary > ------- > > Added killgrp() to process based isolation module. > > Also, updated killtree.sh to catch more zombies. > > > This addresses bug mesos-199. > https://issues.apache.org/jira/browse/mesos-199 > > > Diffs > ----- > > src/slave/process_based_isolation_module.cpp e76339c > > Diff: https://reviews.apache.org/r/5260/diff > > > Testing > ------- > > make check > > > Thanks, > > Vinod > >
