----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5402/#review8781 -----------------------------------------------------------
src/linux/cgroups.hpp <https://reviews.apache.org/r/5402/#comment18586> const & for the Option<double>. src/linux/cgroups.hpp <https://reviews.apache.org/r/5402/#comment18587> Ditto. src/linux/cgroups.cpp <https://reviews.apache.org/r/5402/#comment18588> virtual. src/linux/cgroups.cpp <https://reviews.apache.org/r/5402/#comment18589> This method is also virtual -- also, any reason not to keep this protected? src/linux/cgroups.cpp <https://reviews.apache.org/r/5402/#comment18591> Just like the 'EventListener', this should be a call to terminate. src/linux/cgroups.cpp <https://reviews.apache.org/r/5402/#comment18597> Why not pass timeout into the constructor and put all this logic in 'initialize'? src/linux/cgroups.cpp <https://reviews.apache.org/r/5402/#comment18602> Rather than keep this state, this is a great opportunity to fire off the 'killTasks' requests in parallel, then do a 'collect' on the futures! src/linux/cgroups.cpp <https://reviews.apache.org/r/5402/#comment18592> terminate src/linux/cgroups.cpp <https://reviews.apache.org/r/5402/#comment18593> terminate src/linux/cgroups.cpp <https://reviews.apache.org/r/5402/#comment18601> const & src/linux/cgroups.cpp <https://reviews.apache.org/r/5402/#comment18594> terminate src/linux/cgroups.cpp <https://reviews.apache.org/r/5402/#comment18595> terminate src/linux/cgroups.cpp <https://reviews.apache.org/r/5402/#comment18596> This function can be removed. src/linux/cgroups.cpp <https://reviews.apache.org/r/5402/#comment18599> Just return the future, no need for the Try too. src/linux/cgroups.cpp <https://reviews.apache.org/r/5402/#comment18598> See comment above, this extra dispatch can be removed. - Benjamin Hindman On June 21, 2012, 7:42 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5402/ > ----------------------------------------------------------- > > (Updated June 21, 2012, 7:42 p.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > This patch leverages the freezer subsystem in cgroups to kill all the > processes in a cgroup atomically. > > The main idea is to freeze all the processes in a cgroup first, then send > kill signal to all the proceses. This avoids the need of walking the proc > process tree to kill all processes associated with an executor. In fact, the > original killtree solution assumes that the user processes haven't blocked > the SIGSTOP signal, which may not be true in some cases. > > > Diffs > ----- > > src/linux/cgroups.hpp PRE-CREATION > src/linux/cgroups.cpp PRE-CREATION > src/tests/cgroups_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/5402/diff/ > > > Testing > ------- > > On Linux machine, make check. > > > Thanks, > > Jie Yu > >
