> On July 24, 2012, 6:43 p.m., Benjamin Hindman wrote: > > src/linux/cgroups.hpp, lines 305-306 > > <https://reviews.apache.org/r/5402/diff/8/?file=123393#file123393line305> > > > > Let's just thread the default from the beginning, and use a well typed > > duration such as 'seconds'.
Done. > On July 24, 2012, 6:43 p.m., Benjamin Hindman wrote: > > src/linux/cgroups.cpp, line 1147 > > <https://reviews.apache.org/r/5402/diff/8/?file=123394#file123394line1147> > > > > Kill newline. Done. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5402/#review9402 ----------------------------------------------------------- On July 24, 2012, 10:47 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5402/ > ----------------------------------------------------------- > > (Updated July 24, 2012, 10:47 p.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > This patch leverages the freezer subsystem in cgroups to kill all the > processes in a cgroup atomically. > > The main idea is to freeze all the processes in a cgroup first, then send > kill signal to all the proceses. This avoids the need of walking the proc > process tree to kill all processes associated with an executor. In fact, the > original killtree solution assumes that the user processes haven't blocked > the SIGSTOP signal, which may not be true in some cases. > > > Diffs > ----- > > src/linux/cgroups.hpp cec9e36 > src/linux/cgroups.cpp 93c140f > src/tests/cgroups_tests.cpp 7f0f901 > > Diff: https://reviews.apache.org/r/5402/diff/ > > > Testing > ------- > > On Linux machine, make check. > > > Thanks, > > Jie Yu > >
