----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5858/#review9066 -----------------------------------------------------------
Ship it! src/common/utils.hpp <https://reviews.apache.org/r/5858/#comment19209> A unit test would be good, src/tests/utils_tests.cpp is already handy to add one to. - John Sirois On July 9, 2012, 10:10 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5858/ > ----------------------------------------------------------- > > (Updated July 9, 2012, 10:10 p.m.) > > > Review request for mesos, John Sirois and Vinod Kone. > > > Description > ------- > > Again, a refactor not specific to the configuration/flags refactor, but done > "along the way" (but nicely factored out for your review!). > > > Diffs > ----- > > src/common/utils.hpp c8bdccf > > Diff: https://reviews.apache.org/r/5858/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
