> On July 11, 2012, 4:57 p.m., John Sirois wrote: > > src/common/utils.hpp, line 97 > > <https://reviews.apache.org/r/5858/diff/1/?file=120804#file120804line97> > > > > A unit test would be good, src/tests/utils_tests.cpp is already handy > > to add one to.
I'm going to hold off doing it in this review because this is moving over to stout. I'll add a test there. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5858/#review9066 ----------------------------------------------------------- On July 9, 2012, 10:10 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5858/ > ----------------------------------------------------------- > > (Updated July 9, 2012, 10:10 p.m.) > > > Review request for mesos, John Sirois and Vinod Kone. > > > Description > ------- > > Again, a refactor not specific to the configuration/flags refactor, but done > "along the way" (but nicely factored out for your review!). > > > Diffs > ----- > > src/common/utils.hpp c8bdccf > > Diff: https://reviews.apache.org/r/5858/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
