----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5509/#review9225 -----------------------------------------------------------
src/examples/balloon_executor.cpp <https://reviews.apache.org/r/5509/#comment19746> is 64 arbitrary or is there a reason? just curious src/examples/balloon_executor.cpp <https://reviews.apache.org/r/5509/#comment19745> why do u need to do a memset? src/examples/balloon_executor.cpp <https://reviews.apache.org/r/5509/#comment19747> use numify inside utils. src/examples/balloon_framework.cpp <https://reviews.apache.org/r/5509/#comment19748> i see. so this is where 64 comes from. you should pull this out into a constant. src/slave/cgroups_isolation_module.hpp <https://reviews.apache.org/r/5509/#comment19749> use !infos.contains() here and everywhere else src/slave/cgroups_isolation_module.cpp <https://reviews.apache.org/r/5509/#comment19750> why an unnamed namespace? src/slave/cgroups_isolation_module.cpp <https://reviews.apache.org/r/5509/#comment19780> just do CHECK(os::user == "root") << ... src/slave/cgroups_isolation_module.cpp <https://reviews.apache.org/r/5509/#comment19781> ditto src/slave/cgroups_isolation_module.cpp <https://reviews.apache.org/r/5509/#comment19782> s/listen/listening/ src/slave/cgroups_isolation_module.cpp <https://reviews.apache.org/r/5509/#comment19783> s/happens/happened/ - Vinod Kone On July 17, 2012, 7:49 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5509/ > ----------------------------------------------------------- > > (Updated July 17, 2012, 7:49 p.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > Add the cgroups isolation module. > > > Diffs > ----- > > src/Makefile.am 10f1101 > src/examples/balloon_executor.cpp PRE-CREATION > src/examples/balloon_framework.cpp PRE-CREATION > src/slave/cgroups_isolation_module.hpp PRE-CREATION > src/slave/cgroups_isolation_module.cpp PRE-CREATION > src/slave/isolation_module.cpp 5b7b4a2 > src/tests/cgroups_isolation_tests.cpp PRE-CREATION > src/tests/external/CgroupsIsolation/ROOT_CGROUPS_BalloonFramework.sh > PRE-CREATION > > Diff: https://reviews.apache.org/r/5509/diff/ > > > Testing > ------- > > make check (external test, including OOM tests). > > > Thanks, > > Jie Yu > >
