> On Aug. 1, 2012, 7:19 p.m., Benjamin Hindman wrote: > > src/examples/balloon_executor.cpp, line 38 > > <https://reviews.apache.org/r/5509/diff/5/?file=131825#file131825line38> > > > > Please get '64' from the ExecutorInfo in BallonExecutor::registered.
Done. > On Aug. 1, 2012, 7:19 p.m., Benjamin Hindman wrote: > > src/examples/balloon_framework.cpp, line 120 > > <https://reviews.apache.org/r/5509/diff/5/?file=131826#file131826line120> > > > > Isn't TASK_FINISHED still an exceptional event? Don't you want to > > driver->abort for all status updates? Abort for all states except TASK_FINISHED. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5509/#review9707 ----------------------------------------------------------- On Aug. 1, 2012, 5:33 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5509/ > ----------------------------------------------------------- > > (Updated Aug. 1, 2012, 5:33 a.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > Add the cgroups isolation module. > > > Diffs > ----- > > src/Makefile.am 10f1101 > src/examples/balloon_executor.cpp PRE-CREATION > src/examples/balloon_framework.cpp PRE-CREATION > src/examples/utils.hpp PRE-CREATION > src/slave/cgroups_isolation_module.hpp PRE-CREATION > src/slave/cgroups_isolation_module.cpp PRE-CREATION > src/slave/isolation_module.cpp 5b7b4a2 > src/tests/cgroups_isolation_tests.cpp PRE-CREATION > src/tests/external/CgroupsIsolation/ROOT_CGROUPS_BalloonFramework.sh > PRE-CREATION > > Diff: https://reviews.apache.org/r/5509/diff/ > > > Testing > ------- > > make check (external test, including OOM tests). > > > Thanks, > > Jie Yu > >
