----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5840/#review9403 -----------------------------------------------------------
Again, comments from previous reviews apply here. src/linux/cgroups.cpp <https://reviews.apache.org/r/5840/#comment20141> Kill newline. src/linux/cgroups.cpp <https://reviews.apache.org/r/5840/#comment20145> I think there is a 'discard' that takes a collection of futures (maybe a set not a list, but feel free to add the list version, or anything that can be const_iterator'ed for that matter. src/linux/cgroups.cpp <https://reviews.apache.org/r/5840/#comment20142> LOG(FATAL) src/tests/cgroups_tests.cpp <https://reviews.apache.org/r/5840/#comment20143> Did you want this to be a fatal thing? In the tests, use FAIL() << "message " << variable << " here"; src/tests/cgroups_tests.cpp <https://reviews.apache.org/r/5840/#comment20144> Again, in the tests use FAIL(). - Benjamin Hindman On July 16, 2012, 7:19 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5840/ > ----------------------------------------------------------- > > (Updated July 16, 2012, 7:19 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Description > ------- > > The patch leverages the atomic task kill patch > https://reviews.apache.org/r/5402/ > > It can destroy an active cgroup (and all its sub-cgroups) by killing all > tasks and remove the cgroups in appropriate order. > > It uses the process::collect mechanism to parallelize the killing process. > > > Diffs > ----- > > src/linux/cgroups.hpp PRE-CREATION > src/linux/cgroups.cpp PRE-CREATION > src/tests/cgroups_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/5840/diff/ > > > Testing > ------- > > On linux machines, make check. > > > Thanks, > > Jie Yu > >
