----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5840/#review9911 -----------------------------------------------------------
src/linux/cgroups.cpp <https://reviews.apache.org/r/5840/#comment21080> Done. src/tests/cgroups_tests.cpp <https://reviews.apache.org/r/5840/#comment21086> Done. src/tests/cgroups_tests.cpp <https://reviews.apache.org/r/5840/#comment21088> No, if this assignment fails, the child will exit without writing to the pipe. That will cause one of the "ASSERT_NE(-1, ::read(pipes[0], &dummy, sizeof(dummy)));" fail src/tests/cgroups_tests.cpp <https://reviews.apache.org/r/5840/#comment21089> If the assignment fails here, the child will not write the pipe. This will cause one of the pipe read fail in parent. - Jie Yu On July 24, 2012, 11:25 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5840/ > ----------------------------------------------------------- > > (Updated July 24, 2012, 11:25 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Description > ------- > > The patch leverages the atomic task kill patch > https://reviews.apache.org/r/5402/ > > It can destroy an active cgroup (and all its sub-cgroups) by killing all > tasks and remove the cgroups in appropriate order. > > It uses the process::collect mechanism to parallelize the killing process. > > > Diffs > ----- > > src/linux/cgroups.hpp cec9e36 > src/linux/cgroups.cpp 93c140f > src/tests/cgroups_tests.cpp 7f0f901 > third_party/libprocess/include/process/future.hpp 1da33ad > > Diff: https://reviews.apache.org/r/5840/diff/ > > > Testing > ------- > > On linux machines, make check. > > > Thanks, > > Jie Yu > >
