-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5402/
-----------------------------------------------------------

(Updated July 24, 2012, 10:47 p.m.)


Review request for mesos, Benjamin Hindman and Vinod Kone.


Changes
-------

Addressed Ben's review comments. Make "interval" a well-typed seconds, and set 
default in prototype.


Description
-------

This patch leverages the freezer subsystem in cgroups to kill all the processes 
in a cgroup atomically.

The main idea is to freeze all the processes in a cgroup first, then send kill 
signal to all the proceses. This avoids the need of walking the proc process 
tree to kill all processes associated with an executor. In fact, the original 
killtree solution assumes that the user processes haven't blocked the SIGSTOP 
signal, which may not be true in some cases.


Diffs (updated)
-----

  src/linux/cgroups.hpp cec9e36 
  src/linux/cgroups.cpp 93c140f 
  src/tests/cgroups_tests.cpp 7f0f901 

Diff: https://reviews.apache.org/r/5402/diff/


Testing
-------

On Linux machine, make check.


Thanks,

Jie Yu

Reply via email to