> On July 31, 2012, 6:17 a.m., Bill Farner wrote: > > src/common/values.cpp, line 203 > > <https://reviews.apache.org/r/6224/diff/2/?file=131052#file131052line203> > > > > Some inner parens would be nice to prevent second-guessing the order of > > operations. > > > > Also, ASCII art would be fantastic - i had to stare at this for a bit > > to be convinced that it works. > > Feel free to steal my work below. > > > > // b e > > // current |- - - -| > > // range |- - - -| > > // b e > > // current |- - - -| > > // range |- - - -| > > // b e
Err, well it looked nice in the non fixed-width font for the comment editor, you'd have to adjust the spacing for the b/e markers. - Bill ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6224/#review9625 ----------------------------------------------------------- On July 31, 2012, 5:42 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6224/ > ----------------------------------------------------------- > > (Updated July 31, 2012, 5:42 a.m.) > > > Review request for mesos, Benjamin Hindman and John Sirois. > > > Description > ------- > > See summary. > > > This addresses bug MESOS-247. > https://issues.apache.org/jira/browse/MESOS-247 > > > Diffs > ----- > > src/common/values.cpp 0e9dd4f > src/tests/resources_tests.cpp 3e144ed > > Diff: https://reviews.apache.org/r/6224/diff/ > > > Testing > ------- > > make check > > Please let me know any other tests you can think of. Lets fix ranges foreva. > > > Thanks, > > Vinod Kone > >
