----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6224/#review9654 -----------------------------------------------------------
Ship it! src/common/values.cpp <https://reviews.apache.org/r/6224/#comment20571> Put && on previous line. src/common/values.cpp <https://reviews.apache.org/r/6224/#comment20573> why_you_snake_case? - Benjamin Hindman On July 31, 2012, 5:08 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6224/ > ----------------------------------------------------------- > > (Updated July 31, 2012, 5:08 p.m.) > > > Review request for mesos, Benjamin Hindman and John Sirois. > > > Description > ------- > > See summary. > > > This addresses bug MESOS-247. > https://issues.apache.org/jira/browse/MESOS-247 > > > Diffs > ----- > > src/common/values.cpp 0e9dd4f > src/tests/resources_tests.cpp 3e144ed > > Diff: https://reviews.apache.org/r/6224/diff/ > > > Testing > ------- > > make check > > Please let me know any other tests you can think of. Lets fix ranges foreva. > > > Thanks, > > Vinod Kone > >
