> On Aug. 10, 2012, 4:43 a.m., Vinod Kone wrote: > > src/master/dominant_share_allocator.hpp, line 48 > > <https://reviews.apache.org/r/6505/diff/1/?file=136793#file136793line48> > > > > i thoutht we get self() for free when we inherit Process?
The self() inherited will return process::PID<Allocator>. The compiler won't allow you to pass this to a function that expect process::PID<DominantShareAllocator>. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6505/#review10108 ----------------------------------------------------------- On Aug. 10, 2012, 3 a.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6505/ > ----------------------------------------------------------- > > (Updated Aug. 10, 2012, 3 a.m.) > > > Review request for mesos, Thomas Marshall, John Sirois, and Vinod Kone. > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/master/allocator.hpp c6273b5 > src/master/dominant_share_allocator.hpp ba5dc29 > src/master/dominant_share_allocator.cpp 00a47f7 > src/master/flags.hpp 1227ccc > src/master/master.cpp 4f62687 > src/tests/allocator_tests.cpp b3db13d > src/tests/resource_offers_tests.cpp c004772 > src/tests/utils.hpp a768360 > > Diff: https://reviews.apache.org/r/6505/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
