-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6505/#review10140
-----------------------------------------------------------
This patch causes some allocator tests to fail because the "real" allocator
object that the MockAllocator uses to perform the actual allocation logic isn't
ever getting spawned, and therefore never receives the batch() dispatches. The
easiest way to fix this would be to add:
void SetUp() {
process::spawn(allocator.real)
}
void TearDown() {
process::terminate(allocator.real);
process::wait(allocator.real);
}
to the AllocatorTest class in allocator_test.cpp
- Thomas Marshall
On Aug. 10, 2012, 3 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6505/
> -----------------------------------------------------------
>
> (Updated Aug. 10, 2012, 3 a.m.)
>
>
> Review request for mesos, Thomas Marshall, John Sirois, and Vinod Kone.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/allocator.hpp c6273b5
> src/master/dominant_share_allocator.hpp ba5dc29
> src/master/dominant_share_allocator.cpp 00a47f7
> src/master/flags.hpp 1227ccc
> src/master/master.cpp 4f62687
> src/tests/allocator_tests.cpp b3db13d
> src/tests/resource_offers_tests.cpp c004772
> src/tests/utils.hpp a768360
>
> Diff: https://reviews.apache.org/r/6505/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
