----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5870/#review10371 -----------------------------------------------------------
src/master/simple_allocator_process.hpp <https://reviews.apache.org/r/5870/#comment22052> Please add a comment describing what this struct is and how it gets used below. src/master/simple_allocator_process.hpp <https://reviews.apache.org/r/5870/#comment22051> s/SlaveDedication/Dedication/ src/master/simple_allocator_process.hpp <https://reviews.apache.org/r/5870/#comment22047> Comment this guy. src/master/simple_allocator_process.hpp <https://reviews.apache.org/r/5870/#comment22049> s/slaveDedications/dedications/ src/master/simple_allocator_process.hpp <https://reviews.apache.org/r/5870/#comment22045> const& src/slave/flags.hpp <https://reviews.apache.org/r/5870/#comment22048> Let's make these their own flags. - Benjamin Hindman On Aug. 8, 2012, 10:19 p.m., Thomas Marshall wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5870/ > ----------------------------------------------------------- > > (Updated Aug. 8, 2012, 10:19 p.m.) > > > Review request for mesos. > > > Description > ------- > > Simple implementation of a static allocator. > > This patch depends on 2 other pending code review: > https://reviews.apache.org/r/5599/ > https://reviews.apache.org/r/5913/ > > > This addresses bug MESOS-230. > https://issues.apache.org/jira/browse/MESOS-230 > > > Diffs > ----- > > src/master/simple_allocator_process.hpp PRE-CREATION > src/slave/flags.hpp 0c7917f > src/tests/allocator_tests.cpp b3db13d > src/tests/utils.hpp a768360 > > Diff: https://reviews.apache.org/r/5870/diff/ > > > Testing > ------- > > make check on Lion > new test in allocator_process_tests.cpp > > > Thanks, > > Thomas Marshall > >
