----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5870/#review10553 -----------------------------------------------------------
src/master/hierarchical_allocator_process.hpp <https://reviews.apache.org/r/5870/#comment22582> I believe it should be the case that a SlaveID should be valid. Please assert thusly via: CHECK(slaves.contains(slaveId)); src/master/hierarchical_allocator_process.hpp <https://reviews.apache.org/r/5870/#comment22583> How about: if (slaves[slaveId].has_dedicated_user() && slaves[slaveId].dedicated_user() != frameworks[frameworkId].user()) { return true; } if (slaves[slaveId].has_dedicated_framework() && slaves[slaveId].dedicated_framework() != frameworks[frameworkId].name()) { return true; } return false; src/slave/flags.hpp <https://reviews.apache.org/r/5870/#comment22580> s/Spcifies/Specifies/ src/slave/slave.cpp <https://reviews.apache.org/r/5870/#comment22581> Let's make these optional instead (i.e., 'if (flags.dedicated_user.isSome())'). - Benjamin Hindman On Aug. 16, 2012, 9:13 p.m., Thomas Marshall wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5870/ > ----------------------------------------------------------- > > (Updated Aug. 16, 2012, 9:13 p.m.) > > > Review request for mesos. > > > Description > ------- > > Simple implementation of a static allocator. > > This patch depends on 2 other pending code review: > https://reviews.apache.org/r/5599/ > https://reviews.apache.org/r/5913/ > > > This addresses bug MESOS-230. > https://issues.apache.org/jira/browse/MESOS-230 > > > Diffs > ----- > > include/mesos/mesos.proto 72fccde > src/master/hierarchical_allocator_process.hpp PRE-CREATION > src/slave/flags.hpp 0c7917f > src/slave/slave.cpp 4efd41e > src/tests/allocator_tests.cpp 98efb0d > > Diff: https://reviews.apache.org/r/5870/diff/ > > > Testing > ------- > > make check on Lion > new test in allocator_process_tests.cpp > > > Thanks, > > Thomas Marshall > >
