> On Aug. 15, 2012, 11:30 p.m., Jie Yu wrote: > > src/tests/log_tests.cpp, line 282 > > <https://reviews.apache.org/r/6643/diff/1/?file=141061#file141061line282> > > > > Just curious, is it possible to use Clock::advance() or something like > > that to make the test more robust? (instead of relying on absolute timeout > > which depends on how fast your machine is).
yeah timeouts in tests are pretty evil, that is a question I'll let ben answer for these tests - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6643/#review10374 ----------------------------------------------------------- On Aug. 15, 2012, 7:26 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6643/ > ----------------------------------------------------------- > > (Updated Aug. 15, 2012, 7:26 p.m.) > > > Review request for mesos, Benjamin Hindman and Jie Yu. > > > Description > ------- > > I get some flakiness on my local machine, so bumping up the timeouts. > > > Diffs > ----- > > src/tests/log_tests.cpp 9397da4 > > Diff: https://reviews.apache.org/r/6643/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
