----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6824/#review10876 -----------------------------------------------------------
Ship it! Thanks! This lgtm. The other bit that would be nice to get rid of is abort() in the loads so you can test the failure path and lift abort toa more main-like context where abort decisions seem more appropriate - John Sirois On Aug. 30, 2012, 4:16 a.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6824/ > ----------------------------------------------------------- > > (Updated Aug. 30, 2012, 4:16 a.m.) > > > Review request for mesos, John Sirois and Vinod Kone. > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/Makefile.am aaceee3 > src/flags/flags.hpp aca3be5 > src/flags/loader.hpp d7be7b9 > src/flags/parse.hpp PRE-CREATION > > Diff: https://reviews.apache.org/r/6824/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
