> On Aug. 30, 2012, 4:51 a.m., Vinod Kone wrote: > > src/flags/flags.hpp, line 99 > > <https://reviews.apache.org/r/6824/diff/1/?file=147065#file147065line99> > > > > Flags as a typename is awkward to read. Why not F to be consistent?
Done. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6824/#review10877 ----------------------------------------------------------- On Aug. 30, 2012, 4:16 a.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6824/ > ----------------------------------------------------------- > > (Updated Aug. 30, 2012, 4:16 a.m.) > > > Review request for mesos, John Sirois and Vinod Kone. > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/Makefile.am aaceee3 > src/flags/flags.hpp aca3be5 > src/flags/loader.hpp d7be7b9 > src/flags/parse.hpp PRE-CREATION > > Diff: https://reviews.apache.org/r/6824/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
