----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6863/#review10925 -----------------------------------------------------------
Ship it! I don't think you will be able to run the test on a nest machine as cgroups code requires root permission. You may want to install a virtual machine using vmware fusion. The ubuntu distribution I used was here: http://releases.ubuntu.com/lucid/ubuntu-10.04.4-desktop-amd64.iso For a temp fix, I think this one is OK. The only concern I have is that the download still happens in the child process. If the OS does not reclaim the memory promptly, the assignTask might fail because you try to assign a process that uses more memory than the memory limit of the target cgroup. For the long term, I think we can refactor the ExecutorLauncher so that we always download executors in parent, and keep the logic in child process as simple as possible. - Jie Yu On Aug. 30, 2012, 9:25 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6863/ > ----------------------------------------------------------- > > (Updated Aug. 30, 2012, 9:25 p.m.) > > > Review request for mesos, Benjamin Hindman, Brian Wickman, Jie Yu, and Ben > Mahler. > > > Description > ------- > > This is a short term fix. > > The basic idea is that we split the launcher->run() into setup() and > launch(), and assign the executor process to cgroup after the launch() > > > Diffs > ----- > > src/launcher/launcher.hpp 89cfa8c > src/launcher/launcher.cpp 5267ac2 > src/slave/cgroups_isolation_module.cpp 8a121e0 > third_party/libprocess/include/stout/os.hpp ffe56b6 > > Diff: https://reviews.apache.org/r/6863/diff/ > > > Testing > ------- > > make check succeeds on linux > > but, the cgroups tests seemed to be disabled on my nest machine. are there > any flags that i should use? i suspect the reason for the disabled tests on > linux is because i run bootstrap on my mac and build the bootstrapped branch > on nest. > > > Thanks, > > Vinod Kone > >
