----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6863/#review11307 -----------------------------------------------------------
Ship it! Ship It! - Benjamin Hindman On Sept. 10, 2012, 9:39 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6863/ > ----------------------------------------------------------- > > (Updated Sept. 10, 2012, 9:39 p.m.) > > > Review request for mesos, Benjamin Hindman, Brian Wickman, Jie Yu, and Ben > Mahler. > > > Description > ------- > > This is a short term fix. > > The basic idea is that we split the launcher->run() into setup() and > launch(), and assign the executor process to cgroup after the launch() > > > Diffs > ----- > > src/launcher/launcher.hpp 89cfa8c > src/launcher/launcher.cpp 5267ac2 > src/slave/cgroups_isolation_module.cpp 8a121e0 > third_party/libprocess/include/stout/os.hpp 602db1f > > Diff: https://reviews.apache.org/r/6863/diff/ > > > Testing > ------- > > make check succeeds on linux > > but, the cgroups tests seemed to be disabled on my nest machine. are there > any flags that i should use? i suspect the reason for the disabled tests on > linux is because i run bootstrap on my mac and build the bootstrapped branch > on nest. > > > Thanks, > > Vinod Kone > >
