> On Aug. 30, 2012, 1:13 a.m., Vinod Kone wrote:
> > src/tests/stout_tests.cpp, line 33
> > <https://reviews.apache.org/r/6837/diff/1/?file=147201#file147201line33>
> >
> >     s/3/3.5/ to test double parsing

Added a later check for double parsing.


> On Aug. 30, 2012, 1:13 a.m., Vinod Kone wrote:
> > src/tests/stout_tests.cpp, line 35
> > <https://reviews.apache.org/r/6837/diff/1/?file=147201#file147201line35>
> >
> >     convert all ints to doubles

Done ... but honestly I'm still not sure if I think the 'n.0' style is more 
readable. :(


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6837/#review10868
-----------------------------------------------------------


On Aug. 29, 2012, 7:18 p.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6837/
> -----------------------------------------------------------
> 
> (Updated Aug. 29, 2012, 7:18 p.m.)
> 
> 
> Review request for mesos, John Sirois and Vinod Kone.
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/tests/stout_tests.cpp 91bcc13 
> 
> Diff: https://reviews.apache.org/r/6837/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>

Reply via email to